Avoid locking when scheduling actions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
force-pushed
the
lock-free-actions
branch
from
4a1b809
to
c614a1b
Compare
tanneberger
approved these changes
Aug 22, 2022
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 22, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 23, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Aug 23, 2022
Specifically, this includes the following PRs: - lf-lang/reactor-cpp#22 - lf-lang/reactor-cpp#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the mechanism used for scheduling actions. Instead of managing everything centrally, each action is now responsible for keeping track of its scheduled values. This considerably reduces the work that needs to be done while holding a lock. This patch further redesigns the event queue, such that in most cases scheduling can be done without locking.