Merge pull request #122 from libp2p/fix-abba-bug

fix: fix abba bug in UsefullNewPeer
libp2p · Jun 15, 2023 · 437b9fc · 437b9fc
2 parents 365002e + d7ca005
commit 437b9fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/table.go b/table.go
@@ -120,15 +120,15 @@ func (rt *RoutingTable) UsefulNewPeer(p peer.ID) bool {
 	rt.tabLock.RLock()
 	defer rt.tabLock.RUnlock()
 
-	if rt.Find(p) != "" {
-		// peer already exists in the routing table, so it isn't useful
-		return false
-	}
-
 	// bucket corresponding to p
 	bucketID := rt.bucketIdForPeer(p)
 	bucket := rt.buckets[bucketID]
 
+	if bucket.getPeer(p) != nil {
+		// peer already exists in the routing table, so it isn't useful
+		return false
+	}
+
 	// bucket isn't full
 	if bucket.len() < rt.bucketsize {
 		return true

diff --git a/version.json b/version.json
@@ -1,3 +1,3 @@
 {
-  "version": "v0.6.2"
+  "version": "v0.6.3"
 }