fix: fix abba bug in UsefullNewPeer

[Jorropo]

This fixes a deadlock the issue is that this pattern could happen because .Find inside UsefullNewPeer would aquire the same RLock:

• UsefullNewPeer takes tablock.RLock
• Something else tries to take tablock.Lock (waits)
• UsefullNewPeer calls Find calls NearestPeer call NearestPeers which trie to take tablock.RLock again, here RLock waits because the rwmutex is starving, it will wait for the Something else to aqcuire the Lock first else a constant flow of reader would block the RWMutex forever.

[github-actions]

Suggested version: v0.6.3

Comparing to: v0.6.2 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/libp2p/go-libp2p-kbucket
## incompatible changes
(*RoutingTable).GenRandomKey: removed
(*RoutingTable).UsefulNewPeer: removed

# diagnostics
go.mod: the following requirements are needed
	github.com/ipfs/[email protected]
Run 'go mod tidy' to add missing requirements.

# summary
Suggested version: v0.7.0

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

[guillaumemichel]

Thanks a lot for spotting the bug @Jorropo