Skip to content

Commit

Permalink
review: apply new round of review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
jxs committed Sep 28, 2022
1 parent a91701e commit 33a4aa5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@

- Update to [`libp2p-swarm` `v0.39.1`](swarm/CHANGELOG.md#0391).

- Update to [`libp2p-identify` `v0.39.1`](protocols/identify/CHANGELOG.md#0391).

# 0.48.0

- Update to [`libp2p-core` `v0.36.0`](core/CHANGELOG.md#0360).
Expand Down
2 changes: 2 additions & 0 deletions misc/metrics/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
-
- Update to `libp2p-identify` `v0.39.1`.

- Update to `libp2p-identify` `v0.39.1`.

# 0.9.0

- Update to `libp2p-swarm` `v0.39.0`.
Expand Down
8 changes: 7 additions & 1 deletion protocols/identify/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
//! Implementation of the [Identify] protocol.
//!
//! This implementation of the protocol periodically exchanges
//! [`IdentifyInfo`] messages between the peers on an established connection.
//! [`identify::Info`] messages between the peers on an established connection.
//!
//! At least one identification request is sent on a newly established
//! connection, beyond which the behaviour does not keep connections alive.
Expand Down Expand Up @@ -62,6 +62,12 @@ pub type IdentifyEvent = Event;
#[deprecated(since = "0.40.0", note = "Use libp2p::identify::Behaviour instead.")]
pub type Identify = Behaviour;

#[deprecated(
since = "0.40.0",
note = "Use re-exports that omit `Identify` prefix, i.e. `libp2p::identify::Info`"
)]
pub type IdentifyInfo = Info;

mod behaviour;
mod handler;
mod protocol;
Expand Down
2 changes: 1 addition & 1 deletion swarm-derive/tests/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ fn custom_event_with_either() {
}

impl From<Either<libp2p::ping::PingEvent, libp2p::identify::Event>> for BehaviourOutEvent {
fn from(event: Either<libp2p::ping::PingEvent, libp2p::identify::IdentifyEvent>) -> Self {
fn from(event: Either<libp2p::ping::PingEvent, libp2p::identify::Event>) -> Self {
BehaviourOutEvent::PingOrIdentify(event)
}
}
Expand Down

0 comments on commit 33a4aa5

Please sign in to comment.