Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests related to a missing configuration entry #1315

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Fix tests related to a missing configuration entry #1315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdb88e5
Fix tests related to a missing configuration entry
fbourigault Dec 14, 2020
f7bdc4e
Use latest symfony/phpunit-bridge
fbourigault Dec 15, 2020
6c1fad8
Remove SYMFONY_PHPUNIT_VERSION from travis-ci
fbourigault Dec 15, 2020
b8ea188
Stick with PHPUnit 7.5 for --prefer-lowest and PHP 7.3
fbourigault Dec 15, 2020
016ce36
Set XDEBUG_MODE=coverage for coverage job
fbourigault Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/DependencyInjection/Factory/Loader/FlysystemLoaderFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function testCreateLoaderDefinitionOnCreate(): void
public function testThrowIfFileSystemServiceNotSetOnAddConfiguration(): void
{
$this->expectException(\Symfony\Component\Config\Definition\Exception\InvalidConfigurationException::class);
$this->expectExceptionMessage('The child node "filesystem_service" at path "flysystem" must be configured.');
$this->expectExceptionMessageMatches('/^The child (node|config) "filesystem_service" (at path|under) "flysystem" must be configured\.$/');

$treeBuilder = new TreeBuilder('flysystem');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode')
Expand Down
2 changes: 1 addition & 1 deletion Tests/DependencyInjection/Factory/Loader/StreamLoaderFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function testCreateLoaderDefinitionOnCreate(): void
public function testThrowIfWrapperNotSetOnAddConfiguration(): void
{
$this->expectException(\Symfony\Component\Config\Definition\Exception\InvalidConfigurationException::class);
$this->expectExceptionMessage('The child node "wrapper" at path "stream" must be configured.');
$this->expectExceptionMessageMatches('/^The child (node|config) "wrapper" (at path|under) "stream" must be configured\.$/');

$treeBuilder = new TreeBuilder('stream');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode')
Expand Down
4 changes: 2 additions & 2 deletions Tests/DependencyInjection/Factory/Resolver/AwsS3ResolverFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public function testSetCachePrefixIfDefined(): void
public function testThrowBucketNotSetOnAddConfiguration(): void
{
$this->expectException(\Symfony\Component\Config\Definition\Exception\InvalidConfigurationException::class);
$this->expectExceptionMessage('The child node "bucket" at path "aws_s3" must be configured.');
$this->expectExceptionMessageMatches('/^The child (node|config) "bucket" (at path|under) "aws_s3" must be configured\.$/');

$treeBuilder = new TreeBuilder('aws_s3');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode')
Expand All @@ -311,7 +311,7 @@ public function testThrowBucketNotSetOnAddConfiguration(): void
public function testThrowClientConfigNotSetOnAddConfiguration(): void
{
$this->expectException(\Symfony\Component\Config\Definition\Exception\InvalidConfigurationException::class);
$this->expectExceptionMessage('The child node "client_config" at path "aws_s3" must be configured.');
$this->expectExceptionMessageMatches('/^The child (node|config) "client_config" (at path|under) "aws_s3" must be configured\.$/');

$treeBuilder = new TreeBuilder('aws_s3');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode')
Expand Down