Fix tests related to a missing configuration entry #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception message was changed in symfony/symfony#38176.
Closed
dbu
reviewed
Dec 15, 2020
|
now one last 7.3 build failing :-( |
Let's Symfony PHPUnit Bridge choose the right PHPUnit version. See https://symfony.com/doc/current/components/phpunit_bridge.html#modified-phpunit-script
|
Build is now green! However, there are a lot of skipped tests because of broken detection of There are also some warnings that should be fixed. I will do those in separate PRs. |
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the build which seems broken since Symfony 5.2 is out.
Each kind of issue is solved in it's own commit.
It will focus on fixing the current build without adding untested PHP versions / symfony versions (see #1313).