Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertContains with assertStringContainsString #1317

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Replace assertContains with assertStringContainsString #1317

merged 1 commit into from
Dec 16, 2020

Conversation

fbourigault
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Since #1315, tests are run with PHPUnit 8.3 which deprecates assertContains when using strings.

This PR handle this deprecation to remove some warnings in the CI.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.178% when pulling ad938e6 on fbourigault:assert-string-contains-string into 375d1a2 on liip:master.

@dbu dbu merged commit da5ec9b into liip:master Dec 16, 2020
@dbu
Copy link
Member

dbu commented Dec 16, 2020

thank you!

@fbourigault fbourigault deleted the assert-string-contains-string branch December 16, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @coveralls @dbu