Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flysystem Resolver] Allowing "noPredefinedVisibility" for the visibility config parameter #1389

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

comxd
Copy link
Contributor

@comxd comxd commented Oct 3, 2021

Q A
Branch? 2.0
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

GCP storage buckets now suggest not to use ACL but bucket-wide permissions when possible. Unfortunately trying to upload a file to a bucket using a uniform bucket-level access throws an error:
Cannot insert legacy ACL for an object when uniform bucket-level access is enabled

This PR allows usage of the noPredefinedVisibility value for the "visibility" resolver configuration parameter.

@see

@comxd comxd changed the title [Resolver] Allowing "noPredefinedVisibility" value for the visibility config field [Flysystem Resolver] Allowing "noPredefinedVisibility" value for the visibility config field Oct 3, 2021
Copy link
Contributor Author

@comxd comxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing noPredefinedVisibility can be an another possibility but specific to the Google Cloud Storage adapter.

@comxd comxd changed the title [Flysystem Resolver] Allowing "noPredefinedVisibility" value for the visibility config field [Flysystem Resolver] Allowing NULL for the visibility config parameter Oct 3, 2021
@comxd comxd changed the title [Flysystem Resolver] Allowing NULL for the visibility config parameter [Flysystem Resolver] Allowing "noPredefinedVisibility" for the visibility config parameter Oct 3, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.924% when pulling 95bc20e on comxd:patch-1 into a564b87 on liip:2.x.

@dbu dbu merged commit 573470e into liip:2.x Oct 5, 2021
@dbu
Copy link
Member

dbu commented Oct 5, 2021

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants