[Google Cloud Storage] It should be possible not to use the visibility handler/visibility settings. #1356
Comments
jkuma
changed the title
jkuma
added a commit
to jkuma/flysystem
that referenced
this issue
Sep 21, 2021
…ity handler/visibility settings.
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Report of issue (https://github.com/thephpleague/flysystem-google-cloud-storage/issues/4) from
thephpleague/flysystem-google-cloud-storageSummary
GCP storage buckets now suggest not to use ACL but bucket wide permissions when possible. Unfortunately trying to upload a file to such bucket throws an error:
Cannot insert legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
That was a problem for me, I ended up making a copy of the adapter since it was unable to extend it and just commented out the following line:
'predefinedAcl' => $this->visibilityHandler->visibilityToPredefinedAcl($visibility),
it would be good to actually allow null $defaultVisibility, $dafaultAcl with null works when doing uploads.
How to reproduce
When using GoogleCloudStorage adapter and enabling uniform bucket-level access.
The text was updated successfully, but these errors were encountered: