Fix all test fails in master (just to check) #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since September'2015 Doctrine doesn't always save namespace version in the cache itself: doctrine/cache@ecc4af1 Relying on such kind of implementation detail in a test that is supposed to check if several keys are saved in a cache is kind of pointless, so it makes sense to ignore the cache key that holds a namespace version
AutoRotateFilterLoader tried to throw an exception that didn't exist when it had received an image with invalid EXIF orientation tag. It also used to fall back to exif_read_data when an old Imagine was used and it wasn't tested properly which caused breaking a build. The test is somewhat tricky. I've added an asset with a tiny JPEG that has an EXIF orientation tag. When an old imagine is used, test reads an image into memory, resets the orientation byte and makes ImageInterface mock respond with the modified image when raw JPEG is requested.
lsmith77
added
the
State: Reviewing
lsmith77
added a commit
that referenced
this pull request
Nov 1, 2015
Fix all test fails in master (just to check)
lsmith77
removed
the
State: Reviewing
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a dummy pull request to check #655 and #657 together against travis