Added php_cs.dist / Updated .styleci.yml / Fixed and updated .travis.yml #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
force-pushed
the
feature-phpcsfixer
branch
2 times, most recently
from
49650fe to
a85a35f
Compare
robfrawley
changed the title
robfrawley
force-pushed
the
feature-phpcsfixer
branch
2 times, most recently
from
ef0c92f to
d598d43
Compare
robfrawley
changed the title
robfrawley
force-pushed
the
feature-phpcsfixer
branch
from
d598d43 to
c40b6fc
Compare
|
Looking good! |
lsmith77
added
the
State: Reviewing
|
#793 has been merged |
robfrawley
force-pushed
the
feature-phpcsfixer
branch
2 times, most recently
from
3fccb39 to
f6cbd74
Compare
robfrawley
force-pushed
the
feature-phpcsfixer
branch
from
f6cbd74 to
62debc7
Compare
- Added "friendsofphp/php-cs-fixer:~2.0" development dep. - Added "sllh/php-cs-fixer-styleci-bridge:~2.1" development dep to enable php-cs-fixer configuration directly from .styleci.yml config file. - Updated "styleci.yml" file rule additions (on top of symfony preset): - combine_consecutive_unsets - linebreak_after_opening_tag - no_short_echo_tag - ordered_imports - phpdoc_order - php_unit_construct - php_unit_dedicate_assert - long_array_syntax - Added "sort-packages" to "config" key in "composer.json" - Updated "suggest" key descriptions in "composer.json" for clarity. - Added travis fix for Symfony 2.3 - Fixed bad shell code in travis file. - Added travis fix for Symfony 2.3 in dev require mode. travis fix fixed travis typo fix travis fix bugfix travis cleanup
robfrawley
force-pushed
the
feature-phpcsfixer
branch
from
62debc7 to
8631557
Compare
robfrawley
changed the title
cedricziel
approved these changes
Sep 16, 2016
alexwilson
approved these changes
Sep 16, 2016
lsmith77
removed
the
State: Reviewing
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
php-cs-fixerandphp-cs-fixer-styleci-bridgeas development dependencies, enabling automatic configuration ofbin/php-cs-fixerusing the.styleci.ymlfile.Now, running
php-cs-fixeris easy, which will hopefully provide incentive for regular use of PHP-CS-Fixer:Additional Details
The
.styleci.ymlfile was updated to enable a few additional, sensible options on top of thesymfonypreset. For example, as PHP 5.3 is supported, thelong_array_syntaxrule was added. This caught a bug in the current production code base, seen here.The other, additional rules add consistency I believe worthwhile, such as:
Reference their fixer docs for details about what all the new rules do and provide feedback if you disagree with any of the newly introduced rules.
Original Commit Message