Bugfix for Failing Tests Introduced in #777 #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 😄 |
lsmith77
added
the
State: Reviewing
alexwilson
approved these changes
Sep 14, 2016
lsmith77
removed
the
State: Reviewing
This was referenced Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for failing tests introduced in #777. Sadly, this wasn't caught because the travis config conditional to include
league/flysystemcontained an incorrect conditional that would always resolve to false (due to this line) which caused all flyststem tests to be skipped.So, the tests for this pull requests don't actually test the fix because I inadvertently already fixed the travis file in #792.
So: this special branch includes both this pull request and #792: https://travis-ci.org/src-run/liip-imagine-bundle-sandbox/builds/158721955