-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#362 fix bug Foreign key constraint is incorrectly formed #363
#362 fix bug Foreign key constraint is incorrectly formed #363
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
625079b
to
c0903af
Compare
c0903af
to
d2870ec
Compare
@slnode test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myvo Thank you for your contribution! Can you please add some test(s) to verify your patch and prevent regressions in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myvo Thank you for fixing the issue! Your code LGTM, can you also add a test case for it?
I've just added new test case. Please help me review it again |
@slnode test please |
@myvo , sorry about the late response. Were you able to get the local tests all passed? Jenkins has one test case failing. Could you please take a look if it's caused by your PR? Thanks.
|
@slnode test please |
Hi @dhmlau |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
We just switch the contribution method from CLA to DCO, making your contribution easier in the future. Please sign the commits with DCO by amending your commit messages with
Please refer to this docs page for details. Thanks! For more questions, please join our Slack workspace - #loopback-contributors. |
The issue #362 is fixed.
After checking in MySQL by command
SHOW ENGINE INNODB STATUS;
, I got the reason.We forgot get the MySQL column name before building the Foreign key.