Feature add foreign key on update on delete trigger config #370
Conversation
HugoPoi
requested review from
b-admike,
dhmlau,
jannyHou and
virkt25
as code owners
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
HugoPoi
force-pushed
the
feature/foreign-key-on-config
branch
from
08f6788 to
67345bd
Compare
|
@slnode test please |
|
I'm not sure but some test in datasource juggler in windows node 6.x failed, is it related with my changes ? |
| }); | ||
| rawConstraints.push(match); | ||
| } | ||
| } while (match != null); |
There was a problem hiding this comment.
the while loop is a little bit risky to me, what if the statement doesn't contain the constraint? Maybe change the logic to stop when reaches the last line of the statement.
There was a problem hiding this comment.
the if statement line 54 in the while protect for no match in the CREATE TABLE, I think the tricky part is when someone rework my code later, because the iteration over the Regex is not obvious. Maybe add some comment before the line 52 to explain the iteration on the multiple match with RegExp object internal pointer.
Or is there a other way to iterate with complex RegExp ?
|
@slnode test please |
|
@jannyHou, the CI is all green. Do you think this PR is good to merge? Thanks. |
jannyHou
force-pushed
the
feature/foreign-key-on-config
branch
from
67345bd to
24fe635
Compare
|
@slnode test please |
Description
Add possibility to configure the foreign key constraint with 2 optional triggers.
onUpdateforeign key settingsonDeleteforeign key settingsRelated issues
Checklist
guide