feat: Add support for securityContext in launch form. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
add-support-for-security-context
branch
from
aa2ab61 to
67d14f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage ? 63.80%
=========================================
Files ? 370
Lines ? 8109
Branches ? 1439
=========================================
Hits ? 5174
Misses ? 2935
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
add-support-for-security-context
branch
from
dd122c4 to
519af33
Compare
govalt
reviewed
Dec 29, 2021
Signed-off-by: Jason Porter <[email protected]>
flyte-bot
added a commit
that referenced
this pull request
Dec 29, 2021
# [0.37.0](http://github.com/lyft/flyteconsole/compare/v0.36.0...v0.37.0) (2021-12-29) ### Features * Add support for securityContext in launch form. ([#253](http://github.com/lyft/flyteconsole/issues/253)) ([af1818b](http://github.com/lyft/flyteconsole/commit/af1818b3c92211b12dd0f91fdbafac73b1c190f1))
|
🎉 This PR is included in version 0.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
* Init checkin Signed-off-by: Jason Porter <[email protected]> * Fixed tests on LaunchTaskForm.test Signed-off-by: Jason Porter <[email protected]> * Addressed PR comments Signed-off-by: Jason Porter <[email protected]> Signed-off-by: csirius <[email protected]>
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
# [0.37.0](http://github.com/lyft/flyteconsole/compare/v0.36.0...v0.37.0) (2021-12-29) ### Features * Add support for securityContext in launch form. ([#253](http://github.com/lyft/flyteconsole/issues/253)) ([af1818b](http://github.com/lyft/flyteconsole/commit/af1818b3c92211b12dd0f91fdbafac73b1c190f1)) Signed-off-by: csirius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
securityContextin Admin requests. Currently this feature is not fully rolled out but this change will support bothauthRoleandsecurityContextduring the migration to prevent any breaking changes. The change will appear on Launch/Relaunch/Recover actions. This change also removes the either/or toggle between K8 and IAM roles - now users can enter both/either/none.see: https://github.com/flyteorg/flyteidl/blob/f4809c1a52073ec80de41be109bccc6331cdbac3/protos/flyteidl/core/security.proto#L111
Type
Are all requirements met?
Complete description
FlyteAdmin is planning to migrate to using
securityContextin the future however to support older versions of Admin we will send and receive both values for the time being.Tracking Issue
NA
Follow-up issue
NA