Skip to content

Commit

Permalink
Fix tooltips not visible for NVD3 charts on Firefox (apache#7822) (ap…
Browse files Browse the repository at this point in the history
…ache#7929)

This bug was introduced by apache#7102

Using `position:absolute` on body gives `document.documentElement` a height of 0 which propagates to `clientHeight` on Firefox. This leads to a wrong calculation of the tooltip position in NVD3.

The solution proposed here is to use `min-height: 100vh` instead of the current technique for stretching the body element to the full window height, thus keeping body and html together.
  • Loading branch information
schoel-bis authored and mistercrunch committed Aug 9, 2019
1 parent aebffe0 commit 6df2a71
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions superset/assets/stylesheets/less/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@
@stroke-primary: @brand-primary;

body {
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
min-height: 100vh;
display: flex;
flex-direction: column;
}
Expand Down

0 comments on commit 6df2a71

Please sign in to comment.