Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge apache de6d963 #60

Closed
wants to merge 36 commits into from
Closed

Merge apache de6d963 #60

wants to merge 36 commits into from

Conversation

DiggidyDave
Copy link

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

mistercrunch and others added 30 commits August 18, 2019 22:36
* Improve birth example dashboard

* Fix tests

* pylint
* Adding support for filter box in annotations

* Fixing tox lint errors

* fixing lint errors
* Fix: Chain var declaration and webpack invocation

* enh: Add cross-env to make package.json work cross-platform

* Fix: Update lock-file for new package cross-env

* Chores: Update lock-file for new package cross-env
* bump a set of test-related JS libs

Mostly upgrading jest as I was trying to tackle issues related to
wrong source-maps reporting in jest. This addresses it

* Bumping more things

* lint

* using core-js/stable

* pointing to the right place
* Move more stuff behind ff

* Fix unit tests

* Fix more tests

* Fix lint
…e found (apache#8037)

* fix: handle case where result exists but query cannot be found

* changed error code to 404 for query not found
* dashboard filter indicators

* add/fix unit tests
* Add typing to db_engine_specs

* Add more type annotations and docstrings

* Add docstrings and typing to sql_parse and db_engine_specs

* Refine select_star

* Fix execute and add more docstrings

* Revert kwargs change from execute

* Remove redundant or

* Align view and table getter schema types

* Fix return type of latest_partition

* Remove some typing from presto

* Improve docstring for __extract_from_token
* add new chart plugins

* fix: pin aphrodite version

* fix: package

* fix: unit test dependencies

* fix: memory
Turns out since we use `git archive`, there's no need for `git clean`
which was pretty disruptive.
…pache#7569)

* Separate vis-specific controls from centralized controls

* Remove comment

* Update state's vizType when switching to a new visualization. This fixes the renderTrigger bug.

* Rename functions for better readability

* Fix lint issues

* Fix nits

* Fix vscode rename mistake
* Fix HistogramViz bug.

* Fix ci black error.
* wip

* Finish PR

* Remove annoying snap

* Fix lint

* Fix js tests
* [logging] add query id to logs

* add query_id to hive and presto logging
* removed database deps from reqs-dev.txt and typo.

* Revert requirements-dev.txt to limit scope
* Add LogConfigurator, and add logging for CSV export

* tweak for PR feedback

* fix linter issue
* Add check for calls to cache_key_wrapper to avoid unavoidable compilation of query

* Add fetch_values_predicate to check

* Only check relevant attributes

* Address nit
…ache#8115)

* feat: bump superset-ui dependencies to v0.12 and plugins to v0.11

* fix: update transformProps

* fix: update hooks

* fix: pin lunar version

* fix: lint

* fix: revert table
…row (apache#8069)

* Add support for msgpack results_backend serialization

* Serialize DataFrame with PyArrow rather than JSON

* Adjust dependencies, de-lint

* Add tests for (de)serialization methods

* Add MessagePack config info to Installation docs

* Enable msgpack/arrow serialization by default

* [Fix] Prevent msgpack serialization on synchronous queries

* Add type annotations
craig-rueda and others added 6 commits August 27, 2019 14:51
* Moving towards a whitelist approach for MANIFEST.in when it comes to static resources

* Tuning static exclude

* Fix for fetching version string from package.json, which no longer exists

* Adding package.json fallback for unit tests
@codecov-io
Copy link

Codecov Report

Merging #60 into lyft-master will increase coverage by 8.5%.
The diff coverage is 82.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           lyft-master      #60      +/-   ##
===============================================
+ Coverage        64.63%   73.14%    +8.5%     
===============================================
  Files              478      116     -362     
  Lines            22993    12224   -10769     
  Branches          2503        0    -2503     
===============================================
- Hits             14862     8941    -5921     
+ Misses            7997     3283    -4714     
+ Partials           134        0     -134
Impacted Files Coverage Δ
superset/viz.py 67.75% <0%> (-0.3%) ⬇️
superset/db_engine_specs/impala.py 65% <100%> (+15%) ⬆️
superset/db_engine_specs/bigquery.py 52.23% <100%> (+7.41%) ⬆️
superset/db_engine_specs/sqlite.py 72.41% <100%> (+5.74%) ⬆️
superset/examples/birth_names.py 100% <100%> (ø) ⬆️
superset/db_engine_specs/postgres.py 96.55% <100%> (+1.09%) ⬆️
superset/db_engine_specs/teradata.py 88.88% <100%> (+1.38%) ⬆️
superset/__init__.py 75.78% <100%> (+1.86%) ⬆️
superset/dataframe.py 94.82% <100%> (+0.18%) ⬆️
superset/sql_parse.py 99.22% <100%> (+0.01%) ⬆️
... and 346 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a187b8...cd9c0d2. Read the comment docs.

@DiggidyDave DiggidyDave closed this Dec 3, 2019
@DiggidyDave DiggidyDave deleted the merge-apache-de6d963 branch December 3, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.