-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.3.9 #976
V0.3.9 #976
Conversation
This may sound strange, but will do in the morning. You're awesome! Thanks to both @UziTech and @KostyaTretyak - 0.3.9 release party tomorrow. :) |
Cool, but why not megre this Pull Request? Simple code there, and performance improvements are easy to verify with the |
@KostyaTretyak - Fair question. I will, just not tonight I'm fried and am wondering if we might be able to leverage the power of GitHub a little more. I've added the "Fixes" keyword with reference to both PRs this one covers. This should tell GitHub to close those PRs automatically when I perform the merge. I'm wondering if there are any other PRs or tickets that are open that we can add to this list. Kill two birds (close duplicative issues and PRs) with one stone. For example, @KostyaTretyak, I don't remember exactly, but I think you had an Issue open related to your PR (I don't remember if I closed it). If we add it to the list, we get the reference & the closing. Not asking y'all to go through issues and PRs exactly, just wondering if you know any off the top of your heads that we should add that are covered by this unified PR besides those already listed? |
ps. @KostyaTretyak - sorry, think I missed the point of your question. I think what @UziTech was trying to do was finish off the split we did for a month or so. My fork is already at 0.3.9. Once we get Marked up to the same, I think we can really start looking at the other PRs and package some "sane" releases together. (Focusing on the security vulnerabilities right now as well. Marked is getting flagged in a lot of places.) |
All right, seriously, I should sleep. Thanks again to you both. Happy holidays! Oh, what are the targets for |
In package.json there command
Its using for if (!module.parent) {
process.title = 'marked';
process.exit(main(process.argv.slice()) ? 0 : 1);
} else {
exports = main;
exports.main = main;
exports.runTests = runTests;
exports.runBench = runBench;
exports.load = load;
exports.bench = bench;
module.exports = exports;
} |
This combines #958 (merge from 8fold-marked) and #974 (fix failing tests) and other fixes
All tests are passing 🎉 and minification is done.
@joshbruce We should try to get this pushed out to alleviate nsp https://nodesecurity.io/advisories/531
Fixes #958
Fixes #974
Fixes #555 - see comment
Fixes #925 - see comment
Fixes #926 - see comment