feat: else if to else-if migration

marko-js · Aug 18, 2023 · c6b3b0b · c6b3b0b
1 parent 0044e93
commit c6b3b0b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/.changeset/plenty-stingrays-care.md b/.changeset/plenty-stingrays-care.md
@@ -0,0 +1,5 @@
+---
+"@marko/compat-v4": patch
+---
+
+Migrate if attribute on else tag to an else-if tag.
diff --git a/packages/compat-v4/src/migrate/if-directive.ts b/packages/compat-v4/src/migrate/if-directive.ts
@@ -7,6 +7,21 @@ export default {
     const {
       node: { name, arguments: args },
     } = attr;
+    const tag = attr.parentPath as t.NodePath<t.MarkoTag>;
+    if (
+      name === "if" &&
+      tag.node.name.type === "StringLiteral" &&
+      tag.node.name.value === "else"
+    ) {
+      diagnosticDeprecate(attr, {
+        label: `The "if" attribute on an <else> tag is deprecated. Please use "<else-if>" tag instead.`,
+        fix() {
+          tag.node.arguments = args;
+          tag.node.name = t.stringLiteral("else-if");
+        },
+      });
+      return;
+    }
 
     switch (name) {
       case "if":
@@ -20,12 +35,7 @@ export default {
         return;
     }
 
-    const tag = attr.parentPath as t.NodePath<t.MarkoTag>;
-    if (
-      (tag.node.name.type === "StringLiteral" &&
-        tag.node.name.value === "if") ||
-      willMigrateAllAttrs(tag)
-    ) {
+    if (willMigrateAllAttrs(tag)) {
       return;
     }