Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to mutation style for vite config mutations #34

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Sep 29, 2022

Description

The Vite config plugin hook exposes two apis. You can either mutate the provided config, or return a new config that is deep merged.

For some reason we were doing both which may have been leading to some issues.

This PR updates the code in that plugin hook to only use the mutation style api.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: bd9a98f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 89.47% // Head: 89.54% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (bd9a98f) compared to base (92d047c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   89.47%   89.54%   +0.07%     
==========================================
  Files           6        6              
  Lines         285      287       +2     
  Branches       94       95       +1     
==========================================
+ Hits          255      257       +2     
  Misses         23       23              
  Partials        7        7              
Impacted Files Coverage Δ
src/index.ts 94.38% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 571c993 into main Sep 29, 2022
@DylanPiercey DylanPiercey deleted the config-hook-fixes branch September 29, 2022 20:02
@github-actions github-actions bot mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant