This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DP-6907 change default ordered list type styling in rich text fields (#…
…849) * DP-6907: Add thrid level to ol pattern with lower roman list style * DP-6907: Add another level to the ol pattern and classes to add custom list styles * DP-6907: Add changelog, update markdown file and backstop images * DP-6907: remove jQuery loop and nest styles manually
- Loading branch information
1 parent
24718e8
commit b8ec45e
Showing
9 changed files
with
146 additions
and
30 deletions.
There are no files selected for viewing
Binary file modified
BIN
-12.6 KB
(99%)
backstopjs/reference/regression_page_binder-page-internal_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.01 KB
(100%)
backstopjs/reference/regression_page_binder-page-internal_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-20.2 KB
(98%)
backstopjs/reference/regression_page_regulation_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.98 KB
(100%)
backstopjs/reference/regression_page_regulation_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
___DESCRIPTION___ | ||
Changed | ||
Patch | ||
- DP-6907: Change default ordered list type styling in rich text fields | ||
|
||
___SEMANTIC VERSION (see below)___ | ||
|
||
|
||
___POST DEPLOY STEPS___ | ||
1. Do this | ||
2. Then do this | ||
|
||
___CHANGE TYPES___ | ||
- Added for new features. | ||
- Changed for changes in existing functionality. | ||
- Deprecated for soon-to-be removed features. | ||
- Removed for now removed features. | ||
- Fixed for any bug fixes. | ||
- Security in case of vulnerabilities. | ||
|
||
Note: See http://keepachangelog.com/ for more info about changelogs. | ||
|
||
___CHANGE IMPACT___ | ||
- Minor | ||
- Major | ||
- Patch | ||
|
||
Note: Refer to `docs/versioning.md` for more info about change impact according to semantic versioning. |
54 changes: 39 additions & 15 deletions
54
styleguide/source/_patterns/01-atoms/08-lists/ordered-list.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,40 @@ | ||
{ | ||
"orderedList": [{ | ||
"text": "This is a list item in an ordered list" | ||
},{ | ||
"text": "An ordered list is a list in which the sequence of items is important." | ||
},{ | ||
"text": "Lists can be nested inside of each other", | ||
"sublist" : [{ | ||
"text":"This is a nested list item" | ||
},{ | ||
"text":"This is another nested list item in an ordered list" | ||
}] | ||
},{ | ||
"text":"This is the last list item" | ||
}] | ||
} | ||
"orderedList": [ | ||
{ | ||
"text": "This is a list item in an ordered list" | ||
}, | ||
{ | ||
"text": "An ordered list is a list in which the sequence of items is important. Top level item counters are digits" | ||
}, | ||
{ | ||
"text": "Lists can be nested inside of each other", | ||
"sublist": [ | ||
{ | ||
"text": "This is a nested list item. After digits list items counters are lower-alpha." | ||
}, | ||
{ | ||
"text": "This is another nested list item in an ordered list", | ||
"sublist": [ | ||
{ | ||
"text": "This is a nested list item. After lower-alpha counters, lower-roman counters are used.", | ||
"sublist": [ | ||
{ | ||
"text": "This is a nested list item. After lower-roman counters, the counters loop back to digits." | ||
}, | ||
{ | ||
"text": "This is another nested list item in an ordered list" | ||
} | ||
] | ||
}, | ||
{ | ||
"text": "This is another nested list item in an ordered list" | ||
} | ||
] | ||
} | ||
] | ||
}, | ||
{ | ||
"text": "This is the last list item" | ||
} | ||
] | ||
} |
11 changes: 9 additions & 2 deletions
11
styleguide/source/_patterns/01-atoms/08-lists/ordered-list.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 29 additions & 10 deletions
39
styleguide/source/_patterns/01-atoms/08-lists/ordered-list.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,31 @@ | ||
<ol> | ||
{% for list in orderedList %} | ||
<li>{{ list.text|raw }}</li> | ||
{% if list.sublist %} | ||
<ol> | ||
{% for sublist in list.sublist %} | ||
<li>{{ sublist.text|raw }}</li> | ||
{% endfor %} | ||
</ol> | ||
{% endif %} | ||
{% endfor %} | ||
{% for list in orderedList %} | ||
<li>{{ list.text|raw }} | ||
{% if list.sublist %} | ||
<ol> | ||
{% for sublist in list.sublist %} | ||
<li>{{ sublist.text|raw }} | ||
{% if sublist.sublist %} | ||
<ol> | ||
{% for sublist in sublist.sublist %} | ||
<li>{{ sublist.text|raw }} | ||
{% if sublist.sublist %} | ||
<ol> | ||
{% for sublist in sublist.sublist %} | ||
<li>{{ sublist.text|raw }}</li> | ||
{% endfor %} | ||
</ol> | ||
{% endif %} | ||
</li> | ||
{% endfor %} | ||
</ol> | ||
{% endif %} | ||
</li> | ||
{% endfor %} | ||
</ol> | ||
</li> | ||
{% endif %} | ||
{% endfor %} | ||
</ol> | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters