Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

DP-6907 change default ordered list type styling in rich text fields #849

Conversation

clair0917
Copy link
Contributor

@clair0917 clair0917 commented May 23, 2018

Description

Changes the ol structure to correctly wrap nested ordered lists in list items in Mayflower, to match the correct WYSIWYG layout
Adds a few extra nested lists to the pattern
Adds custom list style type style

Related Issue / Ticket

Steps to Test

  1. Visit /?p=atoms-ordered-list to see the new ordered list style types

Screenshots

screen shot 2018-05-23 at 2 09 26 pm

Notes

The styles are written to accommodate up to 9 nested lists, after which all counters will be digits

@isaacchansky isaacchansky self-requested a review May 23, 2018 20:20
Copy link
Contributor

@isaacchansky isaacchansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nesting is a little gnarly but it's obvious what is going on so I like it 👍

@isaacchansky isaacchansky merged commit b8ec45e into dev May 29, 2018
isaacchansky added a commit that referenced this pull request May 30, 2018
* dev: (21 commits)
  DP-6907  change default ordered list type styling in rich text fields (#849)
  DP-8574  jQuery update for Firefox sticky TOC bug (#822)
  DP-9010  update row order for board pages (#851)
  Update snapshot after merge conflict
  Changelog, snapshot update, and updated comment
  Update press release with image to responsive
  Move to versions of the image for srcset
  Updated the package.json version to 5.25.0
  Removed changelogs txt files for 5.25.0
  Added release notes for 5.25.0
  DP-9057: replace display initial for IE11 compatibility (#843)
  DP-8854: Adjust capitalization in Mass.gov service mark in footer (#846)
  DP-8854: Adjust site footer for use outside of Pattern Lab (#834)
  DP-8631 - Provides twig blocks to support overrides and template mapping of data. (#789)
  Update image to allow srcset and sizes
  DP-8949  subpatterns for general teaser (#837)
  Updated the package.json version to 5.24.0
  Removed changelog txt file for 5.24.0
  Added release notes for 5.24.0
  Contact us: Show more style with only 2 items
  ...
isaacchansky added a commit that referenced this pull request Jun 8, 2018
* dev: (22 commits)
  Updating reference screenshots
  Updating reference screenshots
  update the version for release-5.27.0 in package.json
  update release-notes.md for Release-5.27.0
  DP-8992: Add contact row organism (#841)
  DP-8897: replace the incorrectly pushed backstop files
  DP-8897: updates to backstop files
  update package.json file
  rm old change notes
  update changelog file
  DP-8897: updates to mobile layout
  DP-6907  change default ordered list type styling in rich text fields (#849)
  DP-8897: backstop files
  DP-8897: update some comments for better explinations
  DP-8897: Adds relationship indicator pattern with styles and functionality and adds to org MF page for review
  DP-8574  jQuery update for Firefox sticky TOC bug (#822)
  DP-9010  update row order for board pages (#851)
  Update snapshot after merge conflict
  Changelog, snapshot update, and updated comment
  Update press release with image to responsive
  ...
@isaacchansky isaacchansky deleted the DP-6907--Change-default-ordered-list-type-styling-in-rich-text-fields branch June 11, 2018 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants