Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resizable textareas #1305

Closed
asyncLiz opened this issue May 12, 2020 · 0 comments
Closed

Add resizable textareas #1305

asyncLiz opened this issue May 12, 2020 · 0 comments
Assignees
@asyncLiz
Labels
Type: Feature New feature or request

Comments

@asyncLiz
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
<mwc-textarea> does not have a resize handle like native <textarea>

Describe the solution you'd like
Textareas should either be resizable by default, or static by default. Resizing should be toggle-able by a boolean property (e.g. resize)

Describe alternatives you've considered
Multiline (auto-growing) textareas are another variant that will be explored in #455.

Additional context
Originally MWC disabled resizable textareas since the <textarea> element could be resized outside of the bounds of the <mwc-textarea> element. With recent additions in MDC this is no longer an issue, and resizing can be safely turned on.
@asyncLiz asyncLiz self-assigned this May 12, 2020
@asyncLiz asyncLiz removed their assignment Sep 23, 2020
@asyncLiz asyncLiz self-assigned this Jul 13, 2023
copybara-service bot pushed a commit that referenced this issue Jul 13, 2023
@asyncLiz @copybara-github
feat(textfield): add textarea type
70c76aa 
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like <input>)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
PiperOrigin-RevId: 547614040
@copybara-service copybara-service bot mentioned this issue Jul 13, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Jul 14, 2023
@asyncLiz @copybara-github
feat(textfield): add textarea type
b0b206f 
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 547614040
copybara-service bot pushed a commit that referenced this issue Jul 18, 2023
@asyncLiz @copybara-github
feat(textfield): add textarea type
3eb9b79 
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 547614040
copybara-service bot pushed a commit that referenced this issue Jul 18, 2023
@asyncLiz @copybara-github
feat(textfield): add textarea type
ff2e089 
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 549104722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asyncLiz asyncLiz

Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asyncLiz