Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[textarea] missing icons implementation #2926

Closed
yinonov opened this issue Nov 15, 2021 · 3 comments
Closed

[textarea] missing icons implementation #2926

yinonov opened this issue Nov 15, 2021 · 3 comments
Assignees
Labels
Needs Design Guidance Issues that need input from Material designers to proceed Type: Feature New feature or request

Comments

@yinonov
Copy link

yinonov commented Nov 15, 2021

Describe the bug
textarea documents icon and trailingicon as part of its API but in practice there's no implementation

image

<textarea
aria-labelledby=${ifDefined(ariaLabelledbyOrUndef)}
class="mdc-text-field__input"
.value="${live(this.value) as unknown as string}"
rows="${this.rows}"
cols="${this.cols}"
?disabled="${this.disabled}"
placeholder="${this.placeholder}"
?required="${this.required}"
?readonly="${this.readOnly}"
minlength="${ifDefined(minOrUndef)}"
maxlength="${ifDefined(maxOrUndef)}"
name="${ifDefined(this.name === '' ? undefined : this.name)}"
inputmode="${ifDefined(this.inputMode)}"
autocapitalize="${ifDefined(autocapitalizeOrUndef)}"
@input="${this.handleInputChange}"
@blur="${this.onInputBlur}">
</textarea>`;

Expected behavior
textarea should implement icons in template

@yinonov yinonov added Focus Area: Components Type: Bug Something isn't working labels Nov 15, 2021
@asyncLiz
Copy link
Collaborator

Thanks for the bug! This is definitely a documentation issue since textarea does not have icons.

@asyncLiz asyncLiz added Why: Improve documentation Needs Design Guidance Issues that need input from Material designers to proceed Type: Feature New feature or request and removed Type: Bug Something isn't working labels Nov 15, 2021
@yinonov
Copy link
Author

yinonov commented Nov 15, 2021

couldn't find any ref to textarea in the material.io guidelines.
mind sharing the reasons?

yinonov added a commit to yinonov/material-components-web-components that referenced this issue Nov 15, 2021
@yinonov
Copy link
Author

yinonov commented Nov 16, 2021

oh there's this reference pointing out textarea as a text field type
image

@asyncLiz asyncLiz self-assigned this Jul 13, 2023
copybara-service bot pushed a commit that referenced this issue Jul 13, 2023
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like <input>)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
PiperOrigin-RevId: 547614040
copybara-service bot pushed a commit that referenced this issue Jul 14, 2023
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 547614040
copybara-service bot pushed a commit that referenced this issue Jul 18, 2023
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 547614040
copybara-service bot pushed a commit that referenced this issue Jul 18, 2023
Fixes #4171, #1305, #2926

Changes:
- Added "textarea" type (matches native <textarea>, which has a "type" property like `<input>`)
- Moved pointer-events to the label wrapper so it wouldn't overlap content
- Made resizable field respect min-height
- Remove resize handle when field is disabled
PiperOrigin-RevId: 549104722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Guidance Issues that need input from Material designers to proceed Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants