address feedback from Richard 2022-mar #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had promised to address some feedback from Richard on PR 2418. I went through every comment on the PR that is not yet resolved and came up with two items. Richard, please let me know if I am missing something.
v
flag with set notation and properties of strings tc39/ecma262#2418 (comment)as Richard requested on mar27 in Normative: Add RegExp
v
flag with set notation and properties of strings tc39/ecma262#2418 (comment)except keeping
t
as discussedNote: I do see another comment from March 30 (...restructure regular expression processing for more explicit data propagation...) but don't know what to do with it. I don't think this is one of the things that I promised to fix :-)