Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address feedback from Richard 2022-mar #14

Merged

Conversation

markusicu
Copy link
Collaborator

@markusicu markusicu commented May 30, 2022

I had promised to address some feedback from Richard on PR 2418. I went through every comment on the PR that is not yet resolved and came up with two items. Richard, please let me know if I am missing something.

Note: I do see another comment from March 30 (...restructure regular expression processing for more explicit data propagation...) but don't know what to do with it. I don't think this is one of the things that I promised to fix :-)

@markusicu markusicu marked this pull request as ready for review May 30, 2022 19:16
@markusicu markusicu merged commit a2b562a into regexp-v-flag May 30, 2022
@markusicu markusicu deleted the regexp-v-flag-markus-feedback-from-richard-2022mar branch May 30, 2022 22:11
@mathiasbynens
Copy link
Owner

Note: I do see another comment from March 30 (...restructure regular expression processing for more explicit data propagation...) but don't know what to do with it. I don't think this is one of the things that I promised to fix :-)

I read @gibson042’s comment as a heads-up that this upstream PR is being worked on, and we might need to rebase after it lands — but there’s nothing actionable or blocking for now. Richard, let me know if I misunderstood.

Yay for closing tc39/proposal-regexp-v-flag#24! \o/

@gibson042
Copy link
Collaborator

I read @gibson042’s comment as a heads-up that this upstream PR is being worked on, and we might need to rebase after it lands — but there’s nothing actionable or blocking for now. Richard, let me know if I misunderstood.

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants