-
Notifications
You must be signed in to change notification settings - Fork 12
Advance to Stage 3 #24
Comments
Dear stage 3 reviewers @waldemarhorwat @gibson042 @msaboff -- We have the spec text in the regular format (thanks to @FrankYFTang): https://github.com/tc39/proposal-regexp-set-notation#specification Please review, and let us know if you find bugs, problems, things that are unclear. There are still some sections with yellow background; it would be useful if we could take some of them into the final spec, to add explanations and clarifications, like code comments in programming languages. Can we use NOTEs for them, or just prose nearby? |
This comment has been minimized.
This comment has been minimized.
@waldemarhorwat, @gibson042, @msaboff, our spec PR has already gone through a few rounds of editorial review. Now would be a great time to start your Stage 3 reviews: tc39/ecma262#2418 |
@waldemarhorwat, @gibson042, @msaboff, could you please take a look at our proposed changes and let us know if there are blockers for advancing to stage 3? |
FYI @waldemarhorwat has provided his stage 3 review feedback in issue #54. @mathiasbynens and I have addressed the issues there, with one new PR still pending right now. |
Review done at tc39/ecma262#2418 (review) , some nits and one or two substantial questions but nothing that looks like a Stage 3 blocker. |
During today’s TC39 meeting, the remaining editors signed off on the current version, and we reached consensus for Stage 3 — all of that conditional on us addressing the remaining feedback from @gibson042’s review (which we aim to do as soon as possible). PR: #56 |
@mathiasbynens To clarify, we said we were okay with it advancing to stage 3 without full editor reviews. This doesn't mean the PR will not require any further editorial changes before stage 4, it just means that we are confident we will be able to make them. |
@michaelficarra Ack. We’re happy to address any further feedback. Thanks! |
I believe that I am addressing the last of @gibson042's review comments in mathiasbynens/ecma262#14 |
Criteria taken from the TC39 process document minus those from previous stages:
https://github.com/tc39/proposal-regexp-set-notation#specification
v
flag with set notation and properties of strings ecma262#2418 (review)v
flag with set notation and properties of strings ecma262#2418The text was updated successfully, but these errors were encountered: