Added the test cases for the todo list generated message for Github plugin on MM. #155
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * [MM-41]: added the test cases for todo list on github. * [MM-41]: added the test cases for the todo list. * [MM-41]: small changes. * fixed comments by Aayush for some words changing. * fixed comments by Aayush for some words changing. * [MM-41]: Fixed the comments by Raghav. * [MM-41]: Fixed the comment for notification.
|
@DHaussermann @saturninoabril Can you please have a look at this? |
|
Thanks @arush-vashishtha this all looks accurate to me. |
saturninoabril
requested changes
May 8, 2024
There was a problem hiding this comment.
Thanks @arush-vashishtha, overall looks good to me except for few suggestions.
|
|
||
| **Step 1** | ||
|
|
||
| 1. Connect your MM account to Github account. |
There was a problem hiding this comment.
Please correct proper entity name for "GitHub".
Suggested change
| 1. Connect your MM account to Github account. | |
| 1. Connect your MM account to GitHub account. |
| @@ -0,0 +1,77 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "Todo list in the channel or DM/GM using the `/github todo` command." | |||
There was a problem hiding this comment.
Suggested change
| name: "Todo list in the channel or DM/GM using the `/github todo` command." | |
| name: "Todo list in the channel or DM/GM using the `/github todo` command" |
|
|
||
| **Step 3** | ||
|
|
||
| 1. Merge any desiered open PR on the connected account on github. |
There was a problem hiding this comment.
Suggested change
| 1. Merge any desiered open PR on the connected account on github. | |
| 1. Merge any desired open PR on the connected account on GitHub. |
Comment on lines
+69
to
+77
| **Expected** | ||
|
|
||
| The generated message should show the list for unread messages, review requests, open PRs and user's assignments with the formats, `owner or organisation/repo <event> : <description>` or `owner or organisation/repo : <description>` in the desired channel or DM/GM on MM. | ||
| After step 2, the generated message should not show the closed events in the desired channel or DM/GM on MM. | ||
| After step 3, the desired PR should not be visible in the generated message in the desired channel or DM/GM on MM. | ||
| After step 4, the desired message should not be visible in the generated message in the desired channel or DM/GM on MM. | ||
| After step 5, the desired pending request should not be visible in the generated in the desired channel or DM/GM on MM. | ||
| After step 6, the user should be redirected to the desired owner account or organisation on github respectively. | ||
| After step 7, the user should be redirected to the desired event on github. |
There was a problem hiding this comment.
Please organize the steps/expected format as commented here - #161 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summay
This PR consists the test cases for the updated format of the events in the generated message of
Todolist of Github after running the/github todoslash command on MM.