Added the test cases for the status filter in the subscriptions. #161
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. (#38) * [MM-112]: added the test cases for the status filter in the subscriptions. * Fixed the review fixes Co-authored-by: Raghav Aggarwal <[email protected]> --------- Co-authored-by: Raghav Aggarwal <[email protected]>
lindalumitchell
requested review from
lindalumitchell
and removed request for
lindalumitchell
|
Thanks @arush-vashishtha this all looks accurate to me. Sorry for the delay on this. |
saturninoabril
requested changes
May 8, 2024
There was a problem hiding this comment.
@arush-vashishtha Thanks! Overall looks good except for few comments/typo correction. In addition, Please update the step/expected format to:
**Step 1**
<steps>
**Expected**
<expected>
...
**Step 8**
<steps>
**Expected**
<expected>
| name: "Creating subscriptions for Jira with filter applied on Status field." | ||
| status: Active | ||
| priority: Normal | ||
| folder: Jira-subscriptions |
There was a problem hiding this comment.
Should change to:
Suggested change
| folder: Jira-subscriptions | |
| folder: Jira subscriptions |
| **Step 5** | ||
|
|
||
| 1. After step 4, edit the filter field and click on `Save Subscription` in the `Jira subscriptions` page on MM. | ||
| 2. Trigger the event for the desired subsciption and for the updated filter on Jira. |
There was a problem hiding this comment.
Suggested change
| 2. Trigger the event for the desired subsciption and for the updated filter on Jira. | |
| 2. Trigger the event for the desired subscription and for the updated filter on Jira. |
|
|
||
| The filter field should be visible to the user only after selecting the `Project` and the dropdown options should populate with the desired options in the Jira subscription page on MM. | ||
| After step 2, the user should receive the notification for the subscribed event in the desired channel or DM/GM on MM. | ||
| After step 3, the user should not receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desried channel or DM/GM on MM. |
There was a problem hiding this comment.
Suggested change
| After step 3, the user should not receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desried channel or DM/GM on MM. | |
| After step 3, the user should not receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desired channel or DM/GM on MM. |
| After step 4, the field should be pre-filled for the desired subscription in the `Jira subscriptions` page on MM. | ||
| After step 5, the user should be able to edit the desired subscription on MM. | ||
| After step 6, the filter field should be visible to the user only after selecting the `Project` and the dropdown options should populate with the desired options in the `Jira subscription` page on MM. | ||
| After step 7, the user should not receive the notification for the subscribed event with the desired `Status Type` in the desried channel or DM/GM on MM. |
There was a problem hiding this comment.
Suggested change
| After step 7, the user should not receive the notification for the subscribed event with the desired `Status Type` in the desried channel or DM/GM on MM. | |
| After step 7, the user should not receive the notification for the subscribed event with the desired `Status Type` in the desired channel or DM/GM on MM. |
| After step 5, the user should be able to edit the desired subscription on MM. | ||
| After step 6, the filter field should be visible to the user only after selecting the `Project` and the dropdown options should populate with the desired options in the `Jira subscription` page on MM. | ||
| After step 7, the user should not receive the notification for the subscribed event with the desired `Status Type` in the desried channel or DM/GM on MM. | ||
| After step 8, the user should receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desried channel or DM/GM on MM. |
There was a problem hiding this comment.
Suggested change
| After step 8, the user should receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desried channel or DM/GM on MM. | |
| After step 8, the user should receive the notification for the subscribed event with `Status Type` other than the desired `Status Type` in the desired channel or DM/GM on MM. |
|
|
||
| **Step 1** | ||
|
|
||
| 1. Connect you MM account to your Jira account. |
There was a problem hiding this comment.
Suggested change
| 1. Connect you MM account to your Jira account. | |
| 1. Connect your MM account to your Jira account. |
|
|
||
| **Step 6** | ||
|
|
||
| 1. Connect you MM account to your Jira account. |
There was a problem hiding this comment.
Suggested change
| 1. Connect you MM account to your Jira account. | |
| 1. Connect your MM account to your Jira account. |
This was referenced May 8, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consists the test cases for the following scenarios,