Added the test cases for the context menu features and message access request in to-do list. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge access request in to-do list. (#32) * [MM-70]:Added the test cases for PR 404. * added the test cases for create gitlab issue * [MM-70]: added the test cases for the message attach to gitlab issue. * Fixed the comments by Aayush. * Review fixes by Raghav Co-authored-by: Raghav Aggarwal <[email protected]> * Review fixes by Raghav Co-authored-by: Raghav Aggarwal <[email protected]> --------- Co-authored-by: Raghav Aggarwal <[email protected]>
|
@DHaussermann @saturninoabril Can you please have a look at this? |
|
This looks good @arush-vashishtha. The script looks accurate to me. I will approve for merge once I confirm if we need any further validation of the Zephyr test data. |
saturninoabril
requested changes
May 8, 2024
There was a problem hiding this comment.
Thanks @arush-vashishtha, overall looks good except for few comments.
| name: "Add comment to a gitlab issue from the `Attach to GitLab Issue` option in the context menu on MM." | ||
| status: Active | ||
| priority: Normal | ||
| folder: Context-menu-feature |
There was a problem hiding this comment.
Suggested change
| folder: Context-menu-feature | |
| folder: Context menu feature |
| @@ -0,0 +1,43 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "Add comment to a gitlab issue from the `Attach to GitLab Issue` option in the context menu on MM." | |||
There was a problem hiding this comment.
Suggested change
| name: "Add comment to a gitlab issue from the `Attach to GitLab Issue` option in the context menu on MM." | |
| name: "Add comment to a GitLab issue from the `Attach to GitLab Issue` option in the context menu" |
| @@ -0,0 +1,49 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "Create a Gitlab issue from the `Create Gitlab Issue` in the context menu on MM." | |||
There was a problem hiding this comment.
Suggested change
| name: "Create a Gitlab issue from the `Create Gitlab Issue` in the context menu on MM." | |
| name: "Create a Gitlab issue from the `Create Gitlab Issue` in the context menu" |
| name: "Create a Gitlab issue from the `Create Gitlab Issue` in the context menu on MM." | ||
| status: Active | ||
| priority: Normal | ||
| folder: Context-menu-feature |
There was a problem hiding this comment.
Suggested change
| folder: Context-menu-feature | |
| folder: Context menu feature |
Comment on lines
+46
to
+49
| **Expected** | ||
|
|
||
| The issue should be created for the selected project on Gitlab. | ||
| After step 2, the dropdown menu for additional options should get hidden upon removing the project. |
There was a problem hiding this comment.
Please arrange the format to follow steps/expected as commented here - #161 (review)
| name: "Member access request in the todo list after entering the `/gitlab todo` slash command." | ||
| status: Active | ||
| priority: Normal | ||
| folder: Subscriptions-and-notifications |
There was a problem hiding this comment.
Suggested change
| folder: Subscriptions-and-notifications | |
| folder: Subscriptions and Notifications |
|
|
||
| **Step 1** | ||
|
|
||
| 1. Create a `member access request` from a different user to any one of your desired public project/group on gitlab. |
There was a problem hiding this comment.
Suggested change
| 1. Create a `member access request` from a different user to any one of your desired public project/group on gitlab. | |
| 1. Create a `member access request` from a different user to any one of your desired public project/group on GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consists the test cases for the following scenarios,