Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the test cases for the image in the comment notification. #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
# (Required) Ensure all values are filled up
name: "Image attachment properly shown in the comment notification."
status: Active
priority: Normal
folder: Subscriptions-and-notifications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

Suggested change
folder: Subscriptions-and-notifications
folder: Subscriptions and Notifications

authors: "@arush-vashishtha"
team_ownership: []
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: null

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: null
key: null
created_on: null
last_updated: null
case_hashed: null
steps_hashed: null
---

**Step 1**

1. Connect your MM account to Gitlab account.
2. In the desired channel or DM/GM create subscriptions for `issue_comments` and `merge_request_comments` by using the slash command `/gitlab subscriptions add <owner>/<repo>` on MM.
3. Navigate to the subscribed repository on Gitlab and add an image in the comments to any desired `issue` or `merge request` on Gitlab.
4. Navigate to the desired channel or DM/GM on MM.

**Step 2**

1. Connect your MM account to Gitlab account.
2. In the desired channel or DM/GM create subscriptions for `issue_comments` and `merge_request_comments` by using the slash command `/gitlab subscriptions add <owner>/<repo>` on MM.
3. Navigate to the subscribed repository on Gitlab and add an embedded image in the comments to any desired `issue` or `merge request` on Gitlab.
4. Navigate to the desired channel or DM/GM on MM.

**Expected**

The comment notification in the desired channel or DM/GM on MM should show the proper image attached to the desired `issue` or `merge request` on Gitlab.
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab.
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge request` on Gitlab.