Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the test cases for the image in the comment notification. #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arush-vashishtha
Copy link
Contributor

Summary

This PR consists the test cases for the notification on MM of the Image attached to a comment in a issue or merge request on Gitlab.

…on. (#33)

* [MM-93]: Added the test cases for the image in the comment notification.

* [MM-93]: Fixed the changes required for connect flow.
@lindalumitchell lindalumitchell added the 2: QA Review Requires review by a QA tester label Apr 30, 2024
@DHaussermann DHaussermann self-requested a review May 3, 2024 16:47
@DHaussermann
Copy link
Contributor

This looks good @arush-vashishtha. It's nice to see coverage this deep on the functionality.

The script is fine. I will approve for merge once I confirm if we need any further validation of the Zephyr test data.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arush-vashishtha! Left couple of comments. Lastly, please organized the steps/expected format as also commented at #161 (review).

name: "Image attachment properly shown in the comment notification."
status: Active
priority: Normal
folder: Subscriptions-and-notifications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

Suggested change
folder: Subscriptions-and-notifications
folder: Subscriptions and Notifications

**Expected**

The comment notification in the desired channel or DM/GM on MM should show the proper image attached to the desired `issue` or `merge request` on Gitlab.
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab.
After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge request` on Gitlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants