Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week view hourly events left values are wrong #675

Closed
mattlewis92 opened this issue Aug 6, 2018 · 3 comments · Fixed by #589
Closed

Week view hourly events left values are wrong #675

mattlewis92 opened this issue Aug 6, 2018 · 3 comments · Fixed by #589
Labels

Comments

@mattlewis92
Copy link
Owner

Describe the bug
screen shot 2018-08-05 at 17 06 23

@AhHa45
Copy link

AhHa45 commented Aug 6, 2018

Wouldn't it make sense to add a input property (with a default value) that limits the number of events in a cell? If the limit is reached add a "(# more events)/ (show more)" segment to the cell and clicking on it would open a tooltip where the other events are displayed in a column.

Here is an example from our month view.

more events example

@mattlewis92
Copy link
Owner Author

I have thought about that before but I think it's too opinionated and there's so many things to handle (translating the show more label, how many events to truncate at, building a popover component etc), one of the design goals of this lib was "keep it simple" and provide hooks to extend the functionality via custom templates rather than creating a huge api surface with dozens of options.

@AhHa45
Copy link

AhHa45 commented Aug 7, 2018

I totally understand.
As you can see, it is possible to do it manually in the month view.
However, it was not possible in the week-view, because the grouped events (set in the beforeViewRender function) were not accessible in the template.
I will give it another try now with the 0.26beta-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants