0.26 #589
0.26 #589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 96.66% 97.03% +0.36%
==========================================
Files 34 40 +6
Lines 600 876 +276
Branches 62 116 +54
==========================================
+ Hits 580 850 +270
+ Misses 1 0 -1
- Partials 19 26 +7
Continue to review full report at Codecov.
|
BREAKING CHANGE: date-fns is now no longer a direct dependency of this library. To migrate:
Install date-fns with npm:
```
npm i date-fns
```
Add the date-fns calendar-utils adapter to the first argument of the CalendarModule.forRoot method:
```typescript
import { NgModule } from '@angular/core';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { CalendarModule, DateAdapter } from 'angular-calendar';
import { adapterFactory } from 'angular-calendar/date-adapters/date-fns';
@NgModule({
imports: [
BrowserAnimationsModule,
CalendarModule.forRoot({
provide: DateAdapter,
useFactory: adapterFactory
})
]
})
export class MyModule {}
```
For system.js users you will also need to add the following entries to your systemjs config:
```
'calendar-utils': 'npm:calendar-utils/bundles/calendar-utils.umd.js',
'calendar-utils/date-adapters/date-fns': 'npm:calendar-utils/date-adapters/date-fns.js',
'angular-calendar/date-adapters/date-fns': 'npm:angular-calendar/date-adapters/date-fns.js'
```
BREAKING CHANGE: there were some minor breaking changes in the drag and drop library that might affect your app if you were using it outside of the calendar. See the changelog for more info: https://github.com/mattlewis92/angular-draggable-droppable/blob/master/CHANGELOG.md
BREAKING CHANGE: the moment weekViewColumnSubHeader format has changed for consistency with the other date formatters
BREAKING CHANGE: deep module imports angular-calendar/modules/{common,month,week,day} are no longer supported as the package is now treeshakable. To migrate, adjust your imports to be from angular-calendar directly
BREAKING CHANGE: if you were extending the day view component then the internal API has changed slightly and you may need to adjust your app Closes #532
BREAKING CHANGE: the format of the week view title has changed from `Week d of yyyy` to `MMM d - MMM d, yyyy`. You can override this by using a custom date formatter. Closes #670
| [class.cal-after-hour-start]="!segment.isStart" | ||
| [ngClass]="segment.cssClass"> | ||
| <div class="cal-time" *ngIf="isTimeLabel"> | ||
| {{ segment.date | calendarDate:'weekViewHour':locale }} |
There was a problem hiding this comment.
weekViewHour with locale "de" will make the time segment format like this:
but providing a customHourSegmentTemplate changes it to this:
I don't think this is the wished behavior?
|
@AhHa45 there were some internal breaking changes while I was developing this, check the most up to date example here: https://github.com/mattlewis92/angular-calendar/blob/0.26/demos/demo-modules/moment/module.ts#L14 With your custom hour segment template it looks like you're not hiding the label, check the latest template source here: https://github.com/mattlewis92/angular-calendar/blob/0.26/src/modules/week/calendar-week-view-hour-segment.component.ts (you need the |
|
Is it possible, that events in the week hours view are not properly placed? |
|
@AhHa45 does this help as a starter? https://stackblitz.com/edit/angular-zpkvcd?file=index.html |
|
@mattlewis92 yes thank you: check the 30 min event in the week-view: edit: hm never mind...I can't reproduce it. I have to recheck why my templates have an offset. |
|
Is this ready to go through? Looking forward to a release with the time grid on the week view! |
|
@patrickbadley yup, there's no more breaking changes or features planned for this release, I just wanted to let some people test out the beta version before making it final 😄 |
|
Great, thanks!
…On Wed, Aug 22, 2018 at 11:07 AM Matt Lewis ***@***.***> wrote:
@patrickbadley <https://github.com/patrickbadley> yup, there's no more
breaking changes or features planned for this release, I just wanted to let
some people test out the beta version before making it final 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJAN-SUazU1TdpRQEPUo2G4A8Efqu7IHks5uTXPDgaJpZM4Uh18w>
.
|
|
Hi @mattlewis92 , |
Highlights:
date-fnsis now no longer required, you can usemomentinstead (or write your own date adapter!). It should work making with other timezones a lot easier as date-fns doesn't support this, plus for folks already using moment it should make their bundle sizes smallerAvailable now for testing at:
Full changelog with breaking changes:
Bug Fixes
D MMMtoMMM D(a2fff58)Features
BREAKING CHANGES
Install date-fns with npm:
Add the date-fns calendar-utils adapter to the first argument of the CalendarModule.forRoot method:
For system.js users you will also need to add the following entries to your systemjs config:
allDay: trueon the event to make it appear at the top.People extending the
CalendarWeekViewComponentwill probably have to adjust their child component as the template and internal component api has changed significantly.openDayEventsTemplatefor the month view you must now wrap your template with:and then you must add the collapse animation to the component that contains the open day events
<ng-template>:If using the mwlDraggable directive anywhere else in your app you will need to apply
pointer-events: noneto the element yourself when it's being dragged. This can be done with thedragActiveClassoptionWeek d of yyyytoMMM d - MMM d, yyyy. You can override this by using a custom date formatter.