Skip to content

Commit

Permalink
meshtastic#639 - Move from counting seconds to milliseconds
Browse files Browse the repository at this point in the history
  • Loading branch information
mc-hamster committed Jan 15, 2021
1 parent e395068 commit 507cd1d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 17 deletions.
26 changes: 10 additions & 16 deletions src/airtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@

AirTime *airTime;

// A reminder that there are 3600 seconds in an hour so I don't have
// to keep googling it.
// This can be changed to a smaller number to speed up testing.
//
uint32_t secondsPerPeriod = 3600;

This comment has been minimized.

Copy link
@crossan007

crossan007 Jan 15, 2021

@mc-hamster can you update this to milisecondsPerPeriod so that the units are the same here and in the array

uint32_t lastMillis = 0;
uint32_t secSinceBoot = 0;
Expand All @@ -17,25 +13,23 @@ uint32_t secSinceBoot = 0;

// Don't read out of this directly. Use the helper functions.
struct airtimeStruct {
uint16_t periodTX[periodsToLog]; // AirTime transmitted
uint16_t periodRX[periodsToLog]; // AirTime received and repeated (Only valid mesh packets)
uint16_t periodRX_ALL[periodsToLog]; // AirTime received regardless of valid mesh packet. Could include noise.
uint32_t periodTX[periodsToLog]; // AirTime transmitted
uint32_t periodRX[periodsToLog]; // AirTime received and repeated (Only valid mesh packets)
uint32_t periodRX_ALL[periodsToLog]; // AirTime received regardless of valid mesh packet. Could include noise.
uint8_t lastPeriodIndex;
} airtimes;

void AirTime::logAirtime(reportTypes reportType, uint32_t airtime_ms)
{
// DEBUG_MSG("Packet - logAirtime()\n");

if (reportType == TX_LOG) {
DEBUG_MSG("AirTime - Packet transmitted : %us %ums\n", (uint32_t)round((float)airtime_ms / (float)1000), airtime_ms);
airtimes.periodTX[0] = airtimes.periodTX[0] + round(airtime_ms / 1000);
DEBUG_MSG("AirTime - Packet transmitted : %ums\n", airtime_ms);
airtimes.periodTX[0] = airtimes.periodTX[0] + airtime_ms;
} else if (reportType == RX_LOG) {
DEBUG_MSG("AirTime - Packet received : %us %ums\n", (uint32_t)round((float)airtime_ms / (float)1000), airtime_ms);
airtimes.periodRX[0] = airtimes.periodRX[0] + round(airtime_ms / 1000);
DEBUG_MSG("AirTime - Packet received : %ums\n", airtime_ms);
airtimes.periodRX[0] = airtimes.periodRX[0] + airtime_ms;
} else if (reportType == RX_ALL_LOG) {
DEBUG_MSG("AirTime - Packet received (noise?) : %us %ums\n", (uint32_t)round((float)airtime_ms / (float)1000), airtime_ms);
airtimes.periodRX_ALL[0] = airtimes.periodRX_ALL[0] + round(airtime_ms / 1000);
DEBUG_MSG("AirTime - Packet received (noise?) : %ums\n", airtime_ms);
airtimes.periodRX_ALL[0] = airtimes.periodRX_ALL[0] + airtime_ms;
} else {
DEBUG_MSG("AirTime - Unknown report time. This should never happen!!\n");
}
Expand Down Expand Up @@ -65,7 +59,7 @@ void airtimeRotatePeriod()
}
}

uint16_t *airtimeReport(reportTypes reportType)
uint32_t *airtimeReport(reportTypes reportType)
{

if (reportType == TX_LOG) {
Expand Down
2 changes: 1 addition & 1 deletion src/airtime.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ uint8_t getPeriodsToLog();

uint32_t getSecondsSinceBoot();

uint16_t *airtimeReport(reportTypes reportType);
uint32_t *airtimeReport(reportTypes reportType);

uint32_t getSecondsPerPeriod();

Expand Down

0 comments on commit 507cd1d

Please sign in to comment.