Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update airtime calculation to track in milliseconds instead of seconds #639

Closed
mc-hamster opened this issue Jan 15, 2021 · 2 comments
Closed
Assignees

Comments

@mc-hamster
Copy link
Member

mc-hamster commented Jan 15, 2021

Update airtime calculation to track in milliseconds instead of seconds.

a 24 byte packet at SF7->SF9 with a bandwidth of 125kHz will take at most 267ms. This will be rounded down to 0s in the current implementation.

We need better resolution.

Fix is to switch to 32bit counters and track milliseconds instead. This will double the memory requirement, but it would be needed to track usage of faster spreading factors.

Memory usage can be reduced by changing the number of periods we log.

mc-hamster added a commit to mc-hamster/Meshtastic-device that referenced this issue Jan 15, 2021
@mc-hamster mc-hamster self-assigned this Jan 17, 2021
@mc-hamster
Copy link
Member Author

done

@geeksville
Copy link
Member

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/new-device-alpha-1-1-33/2270/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants