-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite history API guide; delete old example #30354
Conversation
Preview URLs
External URLs (4)URL:
URL:
(comment last updated: 2023-11-20 19:00:48) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nit.
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/history_api/working_with_the_history_api/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Perrier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
…ndex.md Co-authored-by: Jean-Yves Perrier <[email protected]>
Part of #30131.
mdn/dom-examples#236 added a new demo of the History API to dom-examples, to replace the one at https://developer.mozilla.org/en-US/docs/Web/API/History_API/Example which isn't really usable.
This PR deletes the old example page, and also rewrites the guide page at https://developer.mozilla.org/en-US/docs/Web/API/History_API/Working_with_the_History_API to be built around the new example, as I found the previous page not very helpful or easy to understand.
I hope I've not removed important stuff! As usual I don't know this very well so happy with any kind of feedback.
As a drive-by I also updated https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState to fix an error (the corresponding change for
pushState()
was #30169).