Add history api example #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
suggested changes
Nov 17, 2023
| }); | ||
|
|
||
| // Handle forward/back buttons | ||
| window.addEventListener("popstate", (event) => { |
There was a problem hiding this comment.
Yes! This is one case where window is needed! It is the object window (and not the global scope) we are using.
Nice!
Co-authored-by: Jean-Yves Perrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@teoli2003 , the point of this is to replace https://developer.mozilla.org/en-US/docs/Web/API/History_API/Example, which I don't think is viable as an example.
I've used https://github.com/lesjames/history-api-demo, which in turn is based on http://html5doctor.com/history-api/, as a starting point, but have pretty much completely rewritten it.
The general idea is to show how to use the history API to allow back/forward navigation to work when you're doing a single-page app thing using fetch().
However I don't really know what I'm doing here so I'm very open to feedback!