Skip to content

Commit

Permalink
Merge #312
Browse files Browse the repository at this point in the history
312: Update wana_kana to 4.0.0 r=ManyTheFish a=tats-u

# Pull Request

## Related issue

- Fixes #313
- meilisearch/meilisearch#3588 (comment)
- PSeitz/wana_kana_rust#13
- meilisearch/meilisearch@0fbda63
- https://github.com/orgs/meilisearch/discussions/532#discussioncomment-9999921

## What does this PR do?

`wana_kana` used to easily panic. The panicability made it difficult to adopt it in the Meilisearch core. Update it to the latest version that [doesn't panic](https://github.com/orgs/meilisearch/discussions/532#discussioncomment-10814507).

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Tatsunori Uchino <[email protected]>
  • Loading branch information
meili-bors[bot] and tats-u authored Oct 14, 2024
2 parents 1b48ada + bacd1c1 commit 4a16cd3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charabia/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ lindera = { version = "=0.32.2", default-features = false, optional = true }
pinyin = { version = "0.10", default-features = false, features = [
"with_tone",
], optional = true }
wana_kana = { version = "3.0.0", optional = true }
wana_kana = { version = "4.0.0", optional = true }
unicode-normalization = "0.1.23"
irg-kvariants = { path = "../irg-kvariants", version = "=0.1.1" }

Expand All @@ -43,7 +43,7 @@ chinese-normalization-pinyin = ["dep:pinyin", "chinese-normalization"]
hebrew = []

# allow japanese specialized tokenization
japanese = ["japanese-segmentation-unidic"]
japanese = ["japanese-segmentation-unidic", "japanese-transliteration"]
japanese-segmentation-ipadic = ["lindera/ipadic", "lindera/compress"]
japanese-segmentation-unidic = ["lindera/unidic", "lindera/compress"]
japanese-transliteration = ["dep:wana_kana"]
Expand Down

0 comments on commit 4a16cd3

Please sign in to comment.