Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off certain modules not wanted in custom builds #3337

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

caveman99
Copy link
Member

No description provided.

@thebentern
Copy link
Contributor

Good idear! Very Radiolib-esque. Would it make sense to eventually use these in the different architecture base platformio build flags to control the module injections there instead of directly in the modules with the arch macros?

@thebentern thebentern merged commit f5ff77c into master Mar 5, 2024
69 checks passed
@caveman99
Copy link
Member Author

caveman99 commented Mar 5, 2024

Turns out i forgot the inputbroker in the 'nuke all' macro... will revisit tomorrow. It's not a real saving, gives you 2% flash on a t-beam.

I'd like to keep both options available, arch and module macros. this way the tuning is more granular, and you can make 'feature firmwares' for memory restraint devices. Apollo-Router, Apollo-Tracker, Apollo-Sensor and so on.

Also i'd like to propose this as a kind of standard to exclude functionality from builds, even outside the modules. Implementation may be a bit more complicated for other things though. Xmodem comes to mind, or an ESP32 build without webserver (hint, hint)

@jimwhitelaw
Copy link
Contributor

or an ESP32 build without webserver (hint, hint)

I've done most of the work for this in my project already and would be happy to contribute it. Question: with no webserver, is there still a use case for enabling wifi? My code currently assumes there is not and disables both.

@jp-bennett
Copy link
Collaborator

with no webserver, is there still a use case for enabling wifi?

Technically there is still the TCP API, usable through the CLI and a couple apps.

@jimwhitelaw
Copy link
Contributor

OK, thx. My initial work started with disabling wifi and then anything that depended on that, but now that I know it makes sense to have the TCP/wifi and webserver independently enabled, I can re-write to support that.

@garthvh
Copy link
Member

garthvh commented Mar 10, 2024

This is likely to crash when connected to a client app.

@jimwhitelaw
Copy link
Contributor

 @garthvh Can you elaborate? I've been testing and haven't found any crash scenario, just that CLI and web apps fail to connect when webserver is disabled. BT connection with iOS app still works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants