Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configuration option to exclude the webserver on esp32. #3369

Merged
merged 20 commits into from
Mar 21, 2024

Conversation

jimwhitelaw
Copy link
Contributor

Followup to the suggestion by @caveman99 to make including the webserver optional on esp32. Excluding the webserver saves about 8kb of flash on the device and disables the web app and the TCP API. TCP (via wifi or ethernet) remains enabled for use by NTP or MQTT if needed. Tested with tbeam and tlora-v2-1-1_6 devices.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

src/mesh/wifi/WiFiAPClient.cpp Outdated Show resolved Hide resolved
@thebentern thebentern requested a review from caveman99 March 14, 2024 12:46
@jimwhitelaw
Copy link
Contributor Author

@caveman99, I'm not sure what I'm to do about these failing CI checks on files I haven't changed. Can you offer any insight? I've got some additional changes lined up to facilitate minimal builds using the pattern you've initiated (build w/o BT, Wifi, GPS) but I'm struggling to understand what mistake I'm making here. thx

@thebentern thebentern merged commit f4095ce into meshtastic:master Mar 21, 2024
66 of 69 checks passed
@jimwhitelaw jimwhitelaw deleted the no-webserver branch March 25, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants