Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send own node-info earlier and move others to the end of want-config flow #3949

Merged
merged 8 commits into from
May 29, 2024

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented May 21, 2024

@garthvh request.
Needs client testing.

Closes #3740

Addendum:
Clients can send a special want_config_id of 69420 to omit the step of sending other nodeinfos, which is particularly useful for serial proto connected MCUs.

@thebentern
Copy link
Contributor Author

This has been tested on both Android and iOS clients by multiple testers

@thebentern thebentern merged commit af9d825 into master May 29, 2024
82 checks passed
kimgnguyen added a commit to kimgnguyen/meshtastic that referenced this pull request May 29, 2024
commit af9d825
Author: Ben Meadors <[email protected]>
Date:   Tue May 28 19:25:19 2024 -0500

    Send own node-info earlier and move others to the end of want-config flow (meshtastic#3949)

    * Send own node-info earlier and move others to the end of want-config flow

    * Special nonce skips other nodeinfos

    * Missed it

commit 038413f
Author: Neil Hao <[email protected]>
Date:   Tue May 28 19:30:15 2024 +0800

    User experience improvement - app battery icon (meshtastic#3979)

    * 'app_battery_icon'

    * Undo VS automatic modifications to this file

    * 'app_battery_icon_2'
ianmcorvidae added a commit to ianmcorvidae/meshtastic-python that referenced this pull request Jun 6, 2024
@thebentern thebentern deleted the reorder-state-sendnodeinfo branch June 6, 2024 01:55
geeksville pushed a commit to geeksville/Meshtastic-python that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make NodeInfo Optional on WantConfig
1 participant