User experience improvement - app battery icon #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
May 28, 2024
thebentern
reviewed
May 28, 2024
thebentern
approved these changes
May 28, 2024
thebentern
approved these changes
May 28, 2024
kimgnguyen
added a commit
to kimgnguyen/meshtastic
that referenced
this pull request
May 29, 2024
commit af9d825 Author: Ben Meadors <[email protected]> Date: Tue May 28 19:25:19 2024 -0500 Send own node-info earlier and move others to the end of want-config flow (meshtastic#3949) * Send own node-info earlier and move others to the end of want-config flow * Special nonce skips other nodeinfos * Missed it commit 038413f Author: Neil Hao <[email protected]> Date: Tue May 28 19:30:15 2024 +0800 User experience improvement - app battery icon (meshtastic#3979) * 'app_battery_icon' * Undo VS automatic modifications to this file * 'app_battery_icon_2'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Station G2 or any board that does not have the BATTERY_PIN function defined, the current firmware can accurately determine that the board does not have a battery installed.
However, the current firmware will send batteryChargePercent = 0 to the APP for boards without battery, and the APP will display a battery empty icon. Users hope that boards without BATTERY_PIN will display a plug icon in the APP.
Ps. This is a PR about user experience and does not involve any bug fixes.