Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SX126X_ANT_SW for the RAK11200 on the RAK19007 base #4690

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

RealityAnomaly
Copy link
Contributor

Fixes #3338, allows the RAK13300 and GNSS module to function correctly when used on the RAK19007 base with the RAK11200 core module by activating the 3.3V power rail correctly.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

@thebentern thebentern merged commit 3d72fbb into meshtastic:master Sep 12, 2024
106 checks passed
@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

On this board the name is very misleading, SX126X_ANT_SW on this board is not acting to "make analog PA vs not PA switch on SX126x eval board work properly" but to act as a pull-up for a reason unrelated to antenna switching. pca10056-rc-clock uses it for SX1262MB2CAS which acts as the other input to the RF switching IC, the other one being DIO2. Other boards typically hardware invert DIO2 and feed it to that RF switch input. This comment is wrong, as the only board where SX126X_ANT_SW is uncommented (excluding this new addition) doesn't use it for exactly that purpose.

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

Haha, #define SX126X_POWER_EN WB_IO3 and #define SX126X_ANT_SW WB_IO2 are switched but have the same effect

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

Maybe on another base board WB_IO3 is really the SX126X's power switch?

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

RAK5005 also uses IO2 to enable 3V3_S

30 IO2 I/O Used for 3V3_S enable

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

@thebentern what other base boards can carry the RAK11200 and did they work before this change?

@thebentern
Copy link
Contributor

At one time, the legacy RAK-5005 base boards worked, but I have not tested that configuration in quite some time.

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

https://github.com/meshtastic/firmware/blame/master/variants/rak11200/variant.h#L78 done by #1947, I can also see how RF switching evolved in that PR too!

@S5NC
Copy link
Contributor

S5NC commented Sep 12, 2024

At one time, the legacy RAK-5005 base boards worked, but I have not tested that configuration in quite some time.

I suspect if all Wisblock IO (not sensor) connectors are the same, this should create no new issues and potentially fix use with the other boards too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Boot loop on RAK WisBlock ESP32
4 participants