Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rak11200 pin name correction #4691

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Rak11200 pin name correction #4691

merged 6 commits into from
Sep 17, 2024

Conversation

S5NC
Copy link
Contributor

@S5NC S5NC commented Sep 12, 2024

Functionality consistent, some related comments on #4690.

If SX126X_POWER_EN can be initialised in SX126xInterface.cpp, so can SX126X_ANT_SW.

Please trunk fmt

@fifieldt fifieldt force-pushed the rak11200-pin-name-correction branch from 497d65a to bc753e6 Compare September 17, 2024 07:24
fifieldt
fifieldt approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the comments here and in the other bug, this seems to make sense.

It also cleans up main.cpp a little, which I like :)

@caveman99 caveman99 merged commit 4b5bcf5 into meshtastic:master Sep 17, 2024
106 checks passed
@S5NC S5NC deleted the rak11200-pin-name-correction branch September 18, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifieldt fifieldt fifieldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S5NC @fifieldt @caveman99