Increase Pico GPS FIFO Buffer size #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
force-pushed
the
pico-waveshare-gps
branch
from
644df15 to
f122e79
Compare
|
This should be a feature of ARCH_RP2040 and not just that particular board. I recommend extending it. |
fifieldt
force-pushed
the
pico-waveshare-gps
branch
from
f122e79 to
2740f77
Compare
|
@caveman99 - thanks for the tip, updated for ARCH_RP2040 |
fifieldt
force-pushed
the
pico-waveshare-gps
branch
from
2740f77 to
af8bc2f
Compare
caveman99
force-pushed
the
pico-waveshare-gps
branch
from
af8bc2f to
25079f6
Compare
As discovered and tested by @Mictronics, default Serial FIFO size on the Pico is 32bytes, which is not enough for GPS messages. This patch increases the Serial GPS FIFO buffer size to 256 for the RP2040 Architecture fixes meshtastic#3989
caveman99
force-pushed
the
pico-waveshare-gps
branch
from
25079f6 to
4a5eeff
Compare
thebentern
approved these changes
Sep 17, 2024
panaceya
pushed a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Sep 20, 2024
As discovered and tested by @Mictronics, default Serial FIFO size on the Pico is 32bytes, which is not enough for GPS messages. This patch increases the Serial GPS FIFO buffer size to 256 for the RP2040 Architecture fixes meshtastic#3989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered and tested by @Mictronics, default Serial FIFO size on the Pico is 32bytes, which is not enough for GPS messages.
This patch increases the Serial GPS FIFO buffer size to 256 for PICOs only.
fixes #3989