Refactor AccelerometerThread.h #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into accelerometers
fifieldt
reviewed
Sep 24, 2024
fifieldt
force-pushed
the
accelerometers
branch
from
e427456 to
f87998d
Compare
fifieldt
approved these changes
Sep 24, 2024
…into accelerometers
…into accelerometers
fifieldt
approved these changes
Sep 25, 2024
thebentern
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to refactor AccelerometerThread.h into its own folder and tease apart the code into individual classes per sensor to make it easier to add more sensors in future - for more info refer to #4662
It picks up all 6 existing accelerometers, plus adds a basic wake-on-move implementation for a new sensor ICM-20948 (the intent is add digital motion processing for ICM-20948 in a new PR to come)
@thebentern, @fifieldt and @caveman99 - this is a do-over of #4697 that you reviewed last week. Sorry had to cancel that one because of an issue raising the PR from another organisation account. Comments raised have been fixed up in this new PR
This new one should be good to review/test/merge or let me know if anything needs fixing? Thanks