Log cleanups #5135
Merged
Log cleanups #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For your consideration, as an example. If this is a good idea will continue to make similar changes. |
thebentern
reviewed
Oct 26, 2024
thebentern
approved these changes
Oct 26, 2024
caveman99
requested changes
Oct 26, 2024
|
Thanks for the reviews guys, that's helpful to understand how you like your logs. I'll make some fixes and upload a new version. |
thebentern
reviewed
Nov 4, 2024
|
Will pause here -- don't want to add too many changes in one patch; too hard to review :) |
change log levels, shorten log messages, delete commented out logs
thebentern
reviewed
Nov 4, 2024
thebentern
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change log levels, shorten log messages, delete commented out logs