Update GPSUpdateScheduling.cpp #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value is too short, resulting in unstable GPS locks on T1000-E (possibly others). Fix has been tested an confirmed working with no adverse effects, by multiple users. Also discussed at length on Discord
Nestpebble
reviewed
Oct 27, 2024
There was a problem hiding this comment.
I was going to suggest making it T1000E specific, like this:
// Have we been searching for a GPS position for too long?
bool GPSUpdateScheduling::searchedTooLong()
{
#if !defined(_VARIANT_TRACKER_T1000_E_)
uint32_t maxSearchMs =
Default::getConfiguredOrDefaultMs(config.position.position_broadcast_secs, default_broadcast_interval_secs);
#elif defined(_VARIANT_TRACKER_T1000_E_)
// T1000000000E tracker seems to need much longer to search for a decent lock
// The default is 5 minutes (300s). 15 minutes seems to work ok.
uint32_t maxSearchMs = 15*60*1000;
#endifMaybe this is too cumbersome, tho?
|
Interesting. config.position.position_broadcast_secs should already be defaulted to 15 minutes. Are your Seeed studio cards coming pre-configured with 5 minutes? We probably should just put a minimum gate on this value. |
|
The RAK 12500 GPS may also benefit from this change |
|
Updated this with the minimum time coerce logic for now. We'll be revisiting this for a more long term fix that takes into account the extended cold lock times vs subsequent ones, but for now, this fixes a lot of folks having GPS issues |
fifieldt
added a commit
to fifieldt/meshtastic-firmware
that referenced
this pull request
Nov 3, 2024
meshtastic#5160 introduced a change which made first publication of GPS information take up to 15mins. For that initial period, displays would show "No GPS Present", even if one was detected. This change fixes that bug, triggering publication immediately after a GPS module is detected.
fifieldt
added a commit
to fifieldt/meshtastic-firmware
that referenced
this pull request
Nov 3, 2024
meshtastic#5160 introduced a change which made first publication of GPS information take up to 15mins. For that initial period, displays would show "No GPS Present", even if one was detected. This change fixes that bug, triggering publication immediately after a GPS module is detected.
thebentern
pushed a commit
that referenced
this pull request
Nov 3, 2024
#5160 introduced a change which made first publication of GPS information take up to 15mins. For that initial period, displays would show "No GPS Present", even if one was detected. This change fixes that bug, triggering publication immediately after a GPS module is detected.
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
* Update GPSUpdateScheduling.cpp Default value is too short, resulting in unstable GPS locks on T1000-E (possibly others). Fix has been tested an confirmed working with no adverse effects, by multiple users. Also discussed at length on Discord * Coerce minimum instead of hardcode * config --------- Co-authored-by: Ben Meadors <[email protected]>
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
#5160 introduced a change which made first publication of GPS information take up to 15mins. For that initial period, displays would show "No GPS Present", even if one was detected. This change fixes that bug, triggering publication immediately after a GPS module is detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value is too short, resulting in unstable GPS locks on T1000-E (possibly others). Fix has been tested an confirmed working with no adverse effects, by multiple users. Also discussed at length on Discord