Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displays showing "GPS Not Present" until first lock #5229

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

fifieldt
Copy link
Contributor

@fifieldt fifieldt commented Nov 3, 2024

#5160 introduced a change which made first publication of GPS information take up to 15mins. For that initial period, displays would show "No GPS Present", even if one was detected.

This change fixes that bug, triggering publication immediately after a GPS module is detected.

@fifieldt fifieldt marked this pull request as draft November 3, 2024 02:50
meshtastic#5160 introduced a change
which made first publication of GPS information take up to 15mins.
For that initial period, displays would show "No GPS Present", even
if one was detected.

This change fixes that bug, triggering publication immediately after
a GPS module is detected.
@fifieldt fifieldt force-pushed the fix-gps-not-present-bug branch from 63a279a to 6bda6aa Compare November 3, 2024 02:52
@fifieldt fifieldt marked this pull request as ready for review November 3, 2024 02:53
@fifieldt
Copy link
Contributor Author

fifieldt commented Nov 3, 2024

Tested on wio-tracker-wm1110, t114, tbeam.

@thebentern thebentern merged commit 1bec23b into meshtastic:master Nov 3, 2024
48 checks passed
@fifieldt fifieldt deleted the fix-gps-not-present-bug branch November 3, 2024 13:42
caveman99 pushed a commit that referenced this pull request Nov 3, 2024
#5160 introduced a change
which made first publication of GPS information take up to 15mins.
For that initial period, displays would show "No GPS Present", even
if one was detected.

This change fixes that bug, triggering publication immediately after
a GPS module is detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants