Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl compatibility #5219

Merged
merged 7 commits into from
Nov 3, 2024
Merged

musl compatibility #5219

merged 7 commits into from
Nov 3, 2024

Conversation

vidplace7
Copy link
Contributor

@vidplace7 vidplace7 commented Nov 1, 2024

Existing meshtasticd code currently fails to compile with musl.

This PR seeks to resolve compilation errors for musl so that it can be used with buildroot-meshtastic.

Including #include <sys/types.h> resolves issues caused by musl not including uint and ulong type definitions by default.

Cousin PR: meshtastic/framework-portduino#36

@thebentern
Copy link
Contributor

Cousin PR merged!

Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the git reference to portduino must be updated to commit a7d95ec808ae5154cfb49ef293b330083c8f684d to include the Cousin PR here.

@vidplace7
Copy link
Contributor Author

vidplace7 commented Nov 2, 2024

the git reference to portduino must be updated to commit a7d95ec808ae5154cfb49ef293b330083c8f684d to include the Cousin PR here.

meshtastic/platform-native#5 done 👍

Once the platform-native PR is merged, I will update arch/portduino/portduino.ini to reference it in this PR.

@vidplace7 vidplace7 marked this pull request as ready for review November 3, 2024 12:13
@thebentern thebentern requested a review from caveman99 November 3, 2024 12:18
@caveman99 caveman99 merged commit 9415254 into meshtastic:master Nov 3, 2024
47 checks passed
caveman99 pushed a commit that referenced this pull request Nov 3, 2024
* musl compat

* trunk fmt

* Update platform-native, including musl fix

meshtastic/platform-native#5

---------

Co-authored-by: Ben Meadors <[email protected]>
@vidplace7 vidplace7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants